-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add definitions for common HomeLocationStruct and types - see connect… #33569
Add definitions for common HomeLocationStruct and types - see connect… #33569
Conversation
…edhomeip-spec PR 8933
PR #33569: Size comparison from c3ef110 to 0a7ecbd Decreases (1 build for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33569: Size comparison from c3ef110 to 08219ee Increases above 0.2%:
Increases (14 builds for cyw30739, efr32)
Decreases (9 builds for cyw30739, efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
…d5b7eff4d3443273f47f12f22baf 2024-05-23
38fe698
to
893333d
Compare
PR #33569: Size comparison from 3e93ba6 to 893333d Decreases (2 builds for efr32)
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33569: Size comparison from 046fd51 to 6f74d9d Decreases (3 builds for efr32)
Full report (52 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
PR #33569: Size comparison from 046fd51 to ca9d207 Full report (30 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, linux, mbed, nrfconnect, nxp, qpg, stm32)
|
PR #33569: Size comparison from 32c568f to d132cfb Full report (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
|
PR #33569: Size comparison from 32c568f to 568eb3f Full report (6 builds for cc32xx, mbed, qpg, stm32)
|
PR #33569: Size comparison from 44526d2 to 7d60124 Increases above 0.2%:
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33569: Size comparison from 4239c88 to b827762 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #33569: Size comparison from acf823f to b343f80 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #33569: Size comparison from ab42d43 to f6816f9 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #33569: Size comparison from 7c04979 to 12d2543 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
project-chip#33569) * Add definitions for common HomeLocationStruct and types - see connectedhomeip-spec PR 8933 * Fix Carport typo, remove IsGroundFloor field (spec change) * Update home location definitions per spec PR 8933 commit f04958166412d5b7eff4d3443273f47f12f22baf 2024-05-23 * update generated files * Regenerated zap files after merge. * Moved the AreaTypeTag namespace definition to namespaces.xml. * Moved the HomeLoc global struct into global-sturcts.xml. * Updated the AreaTypeTag namespace to match the latest spec definition. * Updated the AreaTypeTag namespace to match the latest spec definition. * Updated the matterlint rules with the changes in the xml files. * Reverted changes to the rvc zap file. * Addded global xml files to relevant lists of xmls. * Added the Position, Landmark and Floor Surface Namespaces. * Explicitly set the conformance. * Added github issue to a comment. * Renamed namespaces.xml to semantic-tag-namespace-enums.xml. * Missed some rename locations. --------- Co-authored-by: jfierke@irobot.com <jfierke@irobot.com>
Fixes #33567
Adds the
In this PR, we have created a
global-structs.xml
file to host any structures that are globally defined in the spec, and anamespaces.xml
file to host any global enums, or namespaces as they are defined in the spec.Currently, these global data types have to be tagged with every cluster that wants to use them, they are not really global! However, there are discussions ongoing to provide a mechanism to make these data-types global and not associated with any cluster.
This is temporary solution to allow the further development of clusters that depend on these data-types.